Application commands followup fix#666
Closed
PenguinDevs wants to merge 4 commits intoPycord-Development:masterfrom
Closed
Application commands followup fix#666PenguinDevs wants to merge 4 commits intoPycord-Development:masterfrom
PenguinDevs wants to merge 4 commits intoPycord-Development:masterfrom
Conversation
Dorukyum
reviewed
Jan 1, 2022
Co-authored-by: Dorukyum <53639936+Dorukyum@users.noreply.github.com>
Lulalaby
added
bug
Contributor
|
Since I've been working on my own version of application command registration, I'm going to close this PR for now and you can apply the fix to my PR if the issue still exists. I'll provide a link to it here once I open it. |
auto-merge was automatically disabled
January 9, 2022 20:05
Pull request was closed
Contributor
|
Here's my PR: #759 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a follow-up of pull request #634 which was to fix the issue of Pycord bulk upserting global commands every single time the bot was started. This pull request is a follow-up for it to fix the issue of subcommands causing an error in the
register_commandsmethod.type: ignorecomments were used, a comment is also left explaining why